List Archive

Thread

Thread Index

Message

From: "Lubomir I. Ivanov" <neolit123%gmail.com@localhost>
To: Thomas Klausner <tk%giga.or.at@localhost>
Subject: Re: Windows cross-build of libzip 1.4.0 fails
Date: Sun, 7 Jan 2018 21:10:59 +0200

On 7 January 2018 at 21:00, Thomas Klausner <tk%giga.or.at@localhost> wrote:
> On Sun, Jan 07, 2018 at 12:46:00AM -0800, Benjamin Gilbert wrote:
>> 3. nonrandomopentest is once again being built, and this time failing with
>> a different error:
>>
>> CMakeFiles/nonrandomopentest.dir/objects.a(nonrandomopentest.c.obj): In
>> function `main':
>> [...]/libzip-1.4.0/regress/nonrandomopentest.c:45: undefined reference to
>> `zip_random'
>>
>> That makes sense, as zip_random is not declared dllexport.
>
> And it shouldn't be exported either in the general case, but it's
> needed for this test to try out if zip_random is used from the
> replacement DLL, or if the original one is used.
>
> Do you have a suggestion on how to solve this? Or should we just skip
> this and the non-random AES encrytion tests on Windows?

ideally, if there are function that don't have to be DLL exported and
still needed for tests, libzip should do both static and dynamic
builds.
the user can decide if he/she wants to use either the static or
dynamic one, yet the tests should only use the static build.

lubomir
--

Made by MHonArc.