List Archive
Thread
-
[PATCH] installing zipconf.h into includedir?,
Pavel Raiskup
(2017/09/06 08:16:27)
-
Re: [PATCH] installing zipconf.h into includedir?,
Thomas Klausner
(2017/10/06 11:06:02)
-
Re: [PATCH] installing zipconf.h into includedir?,
Remi Collet
(2018/01/02 06:36:48)
- Re: [PATCH] installing zipconf.h into includedir?, Thomas Klausner (2018/01/02 08:26:46)
- Re: [PATCH] installing zipconf.h into includedir?, Pavel Raiskup (2018/01/02 08:52:17)
- Message not available
- Re: [PATCH] installing zipconf.h into includedir?, Pavel Raiskup (2018/01/02 13:29:15)
-
Re: [PATCH] installing zipconf.h into includedir?,
Remi Collet
(2018/01/02 06:36:48)
-
Re: [PATCH] installing zipconf.h into includedir?,
Thomas Klausner
(2017/10/06 11:06:02)
Message
On Tue, Jan 02, 2018 at 07:30:21AM +0100, Remi Collet wrote: > Le 06/10/2017 à 13:06, Thomas Klausner a écrit : > > > > On Wed, Sep 06, 2017 at 10:07:24AM +0200, Pavel Raiskup wrote: > >> Please consider the attached patch (the rationale is documented inside). > >> > >> The point is that nowadays, either the projects need to depend on > >> pkg-config or > >> the projects need to use different 'cc -I' option for 32/64bit builds. > >> > >> Alternative would be to install the header into > >> ${includedir}/libzip/zipconf.h > >> or ${includedir}/libzip-private/zipconf.h while changing tze zip.h to: > >> > >> #include <libzip-private/zipconf.h> > >> > >> Thanks for considering, I'd be glad to fix the patch when needed. > > > > Thanks for the patch. > > > > We have discussed this and decided it's time to follow your advice. > > It's committed and pushed. > > zipconf.h is different (again) on 32/64 bit > so this change have to be reverted > > See: https://bugzilla.redhat.com/1529886 Is there no include64 directory or similar? After 1.4.0, I've fixed the installation so you can pass it an include directory. Is that sufficient? Pavel (who requested the change): What does your distribution do about this? Thomas
Made by MHonArc.