List Archive

Thread

Thread Index

Message

From: Remi Collet <remi%fedoraproject.org@localhost>
To: libzip-discuss%nih.at@localhost, praiskup%redhat.com@localhost
Subject: Re: [PATCH] installing zipconf.h into includedir?
Date: Tue, 2 Jan 2018 07:30:21 +0100

Le 06/10/2017 à 13:06, Thomas Klausner a écrit :
> 
> On Wed, Sep 06, 2017 at 10:07:24AM +0200, Pavel Raiskup wrote:
>> Please consider the attached patch (the rationale is documented inside).
>>
>> The point is that nowadays, either the projects need to depend on pkg-config 
>> or
>> the projects need to use different 'cc -I' option for 32/64bit builds.
>>
>> Alternative would be to install the header into 
>> ${includedir}/libzip/zipconf.h
>> or ${includedir}/libzip-private/zipconf.h while changing tze zip.h to:
>>
>>     #include <libzip-private/zipconf.h>
>>
>> Thanks for considering, I'd be glad to fix the patch when needed.
> 
> Thanks for the patch.
> 
> We have discussed this and decided it's time to follow your advice.
> It's committed and pushed.

zipconf.h is different (again) on 32/64 bit
so this change have to be reverted

See: https://bugzilla.redhat.com/1529886


Remi

Attachment: signature.asc
Description: OpenPGP digital signature

Made by MHonArc.