- Re: vcpkg support/static builds, (continued)
Judging be the looks of it, it seems to solve the issue. I will experiment with vcpkg later on, depending on UWP outcome. There will still be a need to patch out the unneeded parts from the build (https://github.com/Microsoft/vcpkg/blob/fe03086399a61745f07079815a1460dbc38c44c3/ports/libzip/enable-static.patch#L21-L36) but likely no source changes necessary for non-UWP builds. Many thanks, Michał. On Mon, Dec 4, 2017 at 10:34 PM, Thomas Klausner <tk%giga.or.at@localhost> wrote: > On Sun, Nov 19, 2017 at 10:29:05AM +0100, Michał Janiszewski wrote: >> I have tried updating libzip vcpkg to 1.3.0 and took a closer look at your >> suggestions and what is going on there. >> Your suggestions to use ZIP_STATIC is perfectly fine, however there is >> still an issue with it. >> ZIP_STATIC can only be set from the build system which is not used anywhere >> in CMakeLists.txt and vcpkg seems to build multiple versions (shared, >> static), each with its own header. >> The patch in vcpkg looks to make just that – ensure each of static and >> shared version can have fully-contained headers. >> Could you change how the ZIP_STATIC is used, so that it can be configured >> (CMake's CONFIGURE_FILE) and stored in a header? > > We've changed ZIP_STATIC support so that it is added to the header in > case you build a static libzip; with the cmake build only. > > See > > https://github.com/nih-at/libzip/commit/6b1e8de92b97f18b56e5397a540ecf0ac63f75fa > > Hope this helps! > Thomas -- Michal Janiszewski
Made by MHonArc.