List Archive
Thread
- Re: Winzip AES support committed, (continued)
-
Re: Winzip AES support committed,
Andrew Molyneux
(2016/12/23 12:39:35)
- Re: Winzip AES support committed, Thomas Klausner (2016/12/24 08:58:03)
-
Re: Winzip AES support committed,
Andrew Molyneux
(2016/12/24 18:53:39)
- Re: Winzip AES support committed, Thomas Klausner (2016/12/25 11:16:52)
-
Re: Winzip AES support committed,
Andrew Molyneux
(2016/12/23 12:39:35)
Message
Hi Andrew! On Sat, Dec 24, 2016 at 06:53:36PM +0000, Andrew Molyneux wrote: > I've attached 2 small patches: > > 1. cmake-gladman-fcrypt.patch fixes build errors due to > gladman-fcrypt.c not being included in CMake builds and the > "lib/gladman-fcrypt" subdirectory not being included in the include > path. > > 2. random-win32.patch adds a Win32 implementation of the zip_random() > function, as requested. It uses the CryptoAPI function > CryptGenRandom() which I believe is suitable for this purpose. One > thing to note: it calls CryptAcquireContext() and > CryptReleaseContext() every time, and I've heard that > CryptAcquireContext() might be slow under some circumstances. If that > did turn out to be an issue, caching the HCRYPTPROV handle somehow > might help. Thank you very much for these! I've applied and pushed them. Happy holidays! Thomas
Made by MHonArc.