List Archive

Thread

Thread Index

Message

From: Thomas Klausner <tk%giga.or.at@localhost>
To: Andrew Molyneux <andrew%molyneuxfamily.co.uk@localhost>
Subject: Re: Winzip AES support committed
Date: Sat, 24 Dec 2016 09:48:40 +0100

On Fri, Dec 23, 2016 at 12:39:31PM +0000, Andrew Molyneux wrote:
> I've just started looking at this, and I've spotted an issue building
> libzip with MSVC. In zip_source_read.c there's pointer arithmetic on
> "void *", which works when compiling with GCC due to an extension, but
> I don't believe is permitted by any C standard. MSVC certainly doesn't
> like it. I've attached a fairly trivial patch for that. Maybe also
> consider using the GCC flag -Wpointer-arith to warn in case that
> creeps in again?

Thanks. I've tested with that flag and fixed the warnings in our code
that gcc reported.

Cheers,
 Thomas

Made by MHonArc.